Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable step bystep screenshot after fail #3119

Merged
merged 9 commits into from
Nov 10, 2021
Merged

Disable step bystep screenshot after fail #3119

merged 9 commits into from
Nov 10, 2021

Conversation

ioannisChalkias
Copy link
Contributor

@ioannisChalkias ioannisChalkias commented Nov 5, 2021 •
edited

Motivation/Description of the PR

  • The stepByStep plugin takes screenshots on every step of the scenario even if the scenario failed it will append the last screenshot to every step after the failing point. So i added a new config option which turn off the saving and in effect the appeding after the failing point.
  • Resolves #issueId (if applicable).

Applicable helpers:

  • WebDriver
  • Puppeteer
  • Nightmare
  • REST
  • FileHelper
  • Appium
  • Protractor
  • TestCafe
  • Playwright

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

retyui and others added 4 commits October 8, 2021 02:29
@retyui
Update mobile-react-native-locators.md (codeceptjs#3067)
f949f27
@gssakash
Added changes to Codecept Tests and Detox (codeceptjs#3087)
52eac98 
I've made a few improvements grammatically and made the content more clear in the 1st point under Codecept Tests.
I've also made a few changes both grammatically and removed spelling errors in the description of the Detox Library
Please let me know if I can make more improvements
Stops saving screenshot after failing points
ebb52a7
Pull request template update & modified plugin description
0faf702
DavertMik
DavertMik requested changes Nov 6, 2021
View reviewed changes
Copy link
Contributor

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense. Should we change default?

lib/plugin/stepByStepReport.js Outdated Show resolved Hide resolved
Arhell
Arhell reviewed Nov 6, 2021
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please resolve conflicts

nikocanvacom
nikocanvacom suggested changes Nov 7, 2021
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
lib/plugin/stepByStepReport.js Show resolved Hide resolved
@Arhell Arhell removed their request for review November 10, 2021 10:16
@DavertMik
Copy link
Contributor

Thanks!

@DavertMik DavertMik merged commit e963695 into codeceptjs:3.x Nov 10, 2021
@Inok Inok mentioned this pull request Apr 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@nikocanvacom nikocanvacom nikocanvacom approved these changes

@DavertMik DavertMik Awaiting requested review from DavertMik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ioannisChalkias @DavertMik @Arhell @nikocanvacom @retyui @gssakash