-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in PR #48 break backward compat? #49
Comments
@nrocy your report is valid. we'll probably have to use |
If you have time please make a PR for this and tag me to merge ASAP |
@TavoNiievez thanks for the quick response, will sort :) |
See #41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #48 replaced deprecated calls to
parents()
withancestors()
but this project package.json seems to allow for symfony/dom-crawler 4.4:^4.4 | ^5.4 | ^6.0
The ancestors() function wasn't added to dom-crawler until 5.3.0-BETA-1 so this seems to be a backward-compat breaking change.
Happy to help assist fix this as it's breaking our tests, how would you prefer to resolve it?
Thanks!
/cc @TavoNiievez
The text was updated successfully, but these errors were encountered: