Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clicking map control for nearby schools reloads nearby schools unnecessarily #278

Open
techieshark opened this issue Nov 2, 2016 · 0 comments

Comments

@techieshark
Copy link
Contributor

We're re-querying unnecessarily

To see it, search for a school (e.g. Darlinghurst Public) and clear your console. No nearby schools are shown.

screen shot 2016-11-01 at 9 19 01 pm

Click to expand the nearby schools control. You'll see a query in the console. That's fine, since it's checking the 'show nearby schools' checkbox for you.

screen shot 2016-11-01 at 9 19 09 pm

Click to collapse the nearby schools control. This shouldn't do reload the nearby schools since they've already been loaded and the user hasn't un-checked the 'show nearby schools' checkbox, but you will notice a new SELECT query in the console.

screen shot 2016-11-01 at 9 19 16 pm

In addition to running queries when we don't need to, the map unloads and loads the set of nearby schools, so you notice them flicker on the map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant