Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semver tasks. #19

Merged
merged 7 commits into from
May 21, 2014
Merged

Add semver tasks. #19

merged 7 commits into from
May 21, 2014

Conversation

jadb
Copy link
Contributor

@jadb jadb commented May 2, 2014

No description provided.

@DavertMik
Copy link
Member

Nice. Can you explain a bit what is semver executable?
I know of sematic versioning, but what application you are executing with this task?

@jadb
Copy link
Contributor Author

jadb commented May 2, 2014

@DavertMik sure. I am using flazz/semver - there are other executables for sure, this is why it is possible to pass your own semver executable's path.

@jadb
Copy link
Contributor Author

jadb commented May 2, 2014

I realize that other semantic versioning executables might have a different API but that was not accounted for in this release. I can easily see how this can be extended to play well with other APIs but someone would need to provide them to me.

@DavertMik
Copy link
Member

It looks pretty useful. But why not have it ported to PHP? Semver is pretty simple.
I'd rather not have a task that depends on a ruby gem.

@jadb
Copy link
Contributor Author

jadb commented May 3, 2014

@DavertMik, as requested (and rightfully so), this task doesn't depend on a ruby gem anymore.

I updated it to use naneau/semver and replicated (only missing format) the gem's API:

  • initialize
  • increment
  • prerelease
  • build (metadata)

And like the gem, it uses the .semver filename.

@jadb
Copy link
Contributor Author

jadb commented May 12, 2014

@DavertMik, any plans on making this part of the core?

@jadb
Copy link
Contributor Author

jadb commented May 12, 2014

I accidently purged my local and remote repos that contained those changes... dumb move.

@DavertMik
Copy link
Member

Finally I got some time to review it. Sorry for taking that long.
I'm mergin this task, but I will add it to Developent trait, as there are all tasks for dev things.

DavertMik added a commit that referenced this pull request May 21, 2014
@DavertMik DavertMik merged commit 5cfde51 into consolidation:master May 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants