Add ImageMinify task #228
Merged
Add ImageMinify task #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minifies images. When the required minifier is not installed on the system the task will try to download it from the imagemin repository. The task supports the following minifiers: - optipng - pngquant - advpng - pngout - zopflipng - pngcrush - gifsicle - jpegoptim - jpeg-recompress - jpegtran - svgo (only minification, no downloading)
|
wow, that's great! Thank you, reviewing... |
|
Thanks, for now I will merge it as it is, but will keep on mind the refactoring ideas you proposed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minifies images. When the required minifier is not installed on the
system the task will try to download it from the imagemin repository.
The task supports the following minifiers:
Note before merging. The task works as intended, generated docs are included, the coding standard was checked. However the class is 603 lines of code and there are a few refactoring possibilities which you might want to consider:
Robo\Task\Assetsnamespace is the right one, maybe a newRobo\Task\Imagesnamespace would be more future proof.findFilesmethod is an exact copy from the FlattenDir task. There is already a discussion about adding glob support for all the tasks. When that happens the findFiles method can be replaced.installFromImageminmethod which basically takes an URL, downloads the content and puts it into a file. Such a general download method could be created in theRobo\Task\Basenamespace, maybe other tasks would benefit from it.