Skip to content
This repository has been archived by the owner on May 5, 2021. It is now read-only.

Partially broken in Firefox #22

Closed
thecodejunkie opened this issue Sep 9, 2014 · 23 comments
Closed

Partially broken in Firefox #22

thecodejunkie opened this issue Sep 9, 2014 · 23 comments
Labels

Comments

@thecodejunkie
Copy link

I just tried the slider in FireFox 32 and it does not quite work. It shows and swaps the images, but there is no transition and no navigation arrows.

@brad-sf
Copy link

brad-sf commented Sep 9, 2014

Hi @thecodejunkie I've just tested the standard demo in my Firefox v 32 on OSX and I can't simulate the issue you are having. Are you on Windows? OSX?

@voigtan
Copy link

voigtan commented Sep 9, 2014

Have the same issue as @thecodejunkie on windows 7, Firefox 32

@brad-sf
Copy link

brad-sf commented Sep 9, 2014

Hmm @voigtan I'm unable to simulate on my Windows 7, Firefox 32 (freshly installed). What URL are you using to test with? Are you getting any Javascript Console errors?

@voigtan
Copy link

voigtan commented Sep 9, 2014

visited http://gilbitron.github.io/Ideal-Image-Slider/index.html and no errors in firebug

@thecodejunkie
Copy link
Author

Windows 7 (x64), Firefox 32 (Disabled all extensions) both in Normal and Incognito modes - No errors
OSX 10.9.4, Firefox 32 (fresh install, no extensions) - Works

@gilbitron
Copy link
Contributor

So it works in Firefox 32 on OSX but not on Windows 7?

@gilbitron gilbitron added the bug label Sep 9, 2014
@florianbrinkmann
Copy link

http://gilbitron.github.io/Ideal-Image-Slider/index.html works for me with Firefox 32 on Windows 7.

@gilbitron
Copy link
Contributor

Ok so can anyone confirm that this is an issue?

@thecodejunkie
Copy link
Author

I am pretty sure we have confirmed it's an issue? Me and @voigtan are on two completely different machines and we've both experienced the same thing on Windows 7 (x64) + Firefox 32

I will also try on my machine at home (same setup) when I get back home later today

@thecodejunkie
Copy link
Author

output

@gilbitron
Copy link
Contributor

Windows 7 (x64), Firefox 32 (Disabled all extensions) both in Normal and Incognito modes - No errors
OSX 10.9.4, Firefox 32 (fresh install, no extensions) - Works

@thecodejunkie Sorry I was getting confused. I thought that in this comment you were saying it works on both.

@florianbrinkmann @voigtan Out of interest are you guys Windows x64 or x32? Use http://supportdetails.com to check.

@thecodejunkie
Copy link
Author

output

Here is OSX.. To be honest it feels a bit sketchy here as well. It works, but when I hover the right side of the image I don't get the arrow

@gilbitron sorry I meant no errors in the console

@florianbrinkmann
Copy link

@gilbitron I'm using Windows x64

@voigtan
Copy link

voigtan commented Sep 9, 2014

Windows 7 x64 and @thecodejunkie gif shows the same problem as I have

@gilbitron
Copy link
Contributor

Ok thanks guys I'll have a look.

@florianbrinkmann
Copy link

slider

@thecodejunkie
Copy link
Author

@florianbrinkmann that could be any browser, any version ;)

@florianbrinkmann
Copy link

@thecodejunkie better now? ;)

slider-zwei

@dedurus
Copy link

dedurus commented Sep 9, 2014

I can confirm the same: Win7 x64, FF31 and FF32.
Commenting the lines
https://github.com/gilbitron/Ideal-Image-Slider/blob/master/ideal-image-slider.js#L410
and
https://github.com/gilbitron/Ideal-Image-Slider/blob/master/ideal-image-slider.js#L411
solves the problem with navigation arrows but not the transition effect problem.
Also, this might make problems on touch devices

// Touch Navigation
            if(('ontouchstart' in window) || window.DocumentTouch && document instanceof DocumentTouch){
                this.settings.effect = 'touch';
                // Commented out lines for FF31+ display of nav arrows
                //previousNav.style.display = 'none';
                //nextNav.style.display = 'none';

                sliderEl.addEventListener('touchstart', _touch.start.bind(this), false);
                sliderEl.addEventListener('touchmove', _touch.move.bind(this), false);
                sliderEl.addEventListener('touchend', _touch.end.bind(this), false);
            }

@thecodejunkie
Copy link
Author

Sorry I noticed that I said Win 7 (x64) but I was actually on a Win 8.1 virtual machine.

Just tried it at home on my Win 7 (x64) with both Firefox 31 and 32 and it works

There are some real inconsistencies going on here =/

@dedurus
Copy link

dedurus commented Sep 9, 2014

Regarding transitions in FF32 (win7 x64): I changed the line
https://github.com/gilbitron/Ideal-Image-Slider/blob/master/ideal-image-slider.js#L369
like this:

// old line
slideEl.style.cssText += '-webkit-transition-duration:'+ this.settings.transitionDuration +'ms;-moz-transition-duration:'+ this.settings.transitionDuration +'ms;-o-transition-duration:'+ this.settings.transitionDuration +'ms;transition-duration:'+ this.settings.transitionDuration +'ms;';

// changed line (changed 'moz-transition-duration' to 'moz-transition'
slideEl.style.cssText += '-webkit-transition-duration:'+ this.settings.transitionDuration +'ms;-moz-transition:'+ this.settings.transitionDuration +'ms;-o-transition-duration:'+ this.settings.transitionDuration +'ms;transition-duration:'+ this.settings.transitionDuration +'ms;';

and transitions are working

@gilbitron
Copy link
Contributor

I've just tested this on:

  • OS X 10.9.4 / Firefox 32 = works fine
  • Win7 x32 (Virtualbox) / Firefox 32 = works fine

@gilbitron
Copy link
Contributor

I'm going to close this for the moment and put it down to browser inconsistencies. If it comes up again I'll have another look at it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants