Remove non needed global parameters #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavierCane
reviewed
Oct 8, 2018
There was a problem hiding this comment.
1 critical comment to review regarding the secret parameter. Take a look when you have time please @rgomezcasas 🙌
Thanks!
| - { resource: ../../../../global/config/config.yml } | ||
|
|
||
|
|
||
| # - { resource: parameters.yml } |
| - { resource: logs.yml } | ||
| - { resource: symfony.yml } | ||
|
|
||
|
|
||
| framework: | ||
| secret: '%secret%' | ||
| secret: 'secret' |
There was a problem hiding this comment.
Why have you removed the parameter % keyword?
This way we would be setting the hardcoded secret string as the application string. That could be considered as a security bad practice because it isn't too much complex, and we would be exposing it in our public repo, doesn't we?
Furthermore, this is what make us do not pass the SymfonyInsight validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.