Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full installation of Xcode is required #89

Open
JavierCane opened this issue Feb 11, 2021 · 2 comments
Open

Full installation of Xcode is required #89

JavierCane opened this issue Feb 11, 2021 · 2 comments

Comments

@JavierCane
Copy link
Member

As per #69, we would be automatically installing the Command Line Tools in order to have git available during dotly install:

dotly/installer

Lines 98 to 113 in 4828b14

case "$OSTYPE" in
darwin*)
_a "Checking if Command Line Tools are installed 🕵️‍♂️"
xcode-select --install 2>&1 | grep installed > /dev/null
if [[ $? ]]; then
_a "Installing Command Line Tools 📺"
xcode-select --install
_q "Press a key after command line tools has finished to continue...👇" "CLT_INSTALLED"
fi
;;
*)
_e "Could not install git, no package provider found"
exit 1
;;
esac

However, it seems that we would need an entire installation of Xcode in order to run mas:

%  bash <(curl -s https://raw.githubusercontent.com/CodelyTV/dotly/master/installer)
  ┌────────────────────────────────────┐
~ │ 🚀 Welcome to the dotly installer!~
  └────────────────────────────────────┘

🤔 Where do you want your dotfiles to be located? (default ~/.dotfiles): 
 > Initializing your dotfiles git repository
 > Cloning dotly
 > Installing dotly dependencies
 > 🍎 Setting up macOS platform
 > Installing needed gnu packages
Error: No such keg: /opt/homebrew/Cellar/bash
Error: No such keg: /opt/homebrew/Cellar/zsh
Error: No such keg: /opt/homebrew/Cellar/coreutils
Error: No such keg: /opt/homebrew/Cellar/make
Error: No such keg: /opt/homebrew/Cellar/gnu-sed
Error: No such keg: /opt/homebrew/Cellar/findutils
Error: No such keg: /opt/homebrew/Cellar/bat
Error: No such keg: /opt/homebrew/Cellar/hyperfine
 > Installing mas
Error: No such keg: /opt/homebrew/Cellar/mas
mas: A full installation of Xcode.app 10.2 is required to compile
this software. Installing just the Command Line Tools is not sufficient.

Xcode can be installed from the App Store.
Error: An unsatisfied requirement failed this build.

It seems that we would not be able to automate the installation of Xcode. You have to manually install it through the App Store, or downloading it from the Apple Developer website after signing in with your Developer ID.

Would you find useful if even if having to do this by hand, we handle this error and instruct the user on how to proceed?

@rgomezcasas
Copy link
Member

I've been there… Once you install the Xcode (1h process) you'll be able to install mas, but not to execute it, since they have a bug

The only way to run mas is using rosetta. We could download a new release and install it manually.

For now, I'll disable the mas installation on apple silicon devices.

What do you think?

@JavierCane
Copy link
Member Author

Good one. Thanks!

It seems they also have this PR waiting for some modifications due to the Homebrew 3 upgrade ☺️

Would you find OK if I rename this issue to something like "Add mas support for Apple Silicon (arm64)" and keep it open until we can actually solve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants