Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

Feedback issues 5/5/2105 #48

Closed
dberesford opened this issue May 5, 2015 · 11 comments
Closed

Feedback issues 5/5/2105 #48

dberesford opened this issue May 5, 2015 · 11 comments
Assignees

Comments

@dberesford
Copy link
Contributor

Feedback email from @tangentfairy and the team:

Here's some feedback from myself, the main issue being that at the moment I cannot get past the "Champion Registration" step. I know it was working last week so something must have changed.

  1. I cannot input email address and full name. Form doesn't allow me. See screenshot. This works if I refresh the page, then those fields are prefilled with what I entered on the previous page. - Fixed

I cannot select a country on this page either. It works if I refresh too. Laura says it does not work for her on refresh. - Fixed

  1. The loading of the page looks very odd when I refresh. If I have already gotten to step 2, it appears to load step 1 and then redirect and load step 2. Can we make it just appear to load step 2? - Fixed

  2. The date of birth field looks great with the calendar, but if I am on City/Town, I fill out City/Town and then I tab to the next field, the calendar doesn't come up. Can we change this so the calendar comes up when you tab to the to Date of Birth field?

  3. If I enter a town that doesn't exist in the geocoder, E.g. "Catania" in "Italy" - then it blanks out my entry when I go to another text field. Are we allowed to enter a dojo that isn't geocoded? If it doesn't show up can we have a map show up to pinpoint the town?

It seems really difficult to understand that you need to pick an option from the list for the city/town field. If I typed in "Enniscorthy" and then didn't select "Enniscorthy, Loch Garman, Leinster", then how do I know I have to select that option?
we need to fix the validation here, the place field is required but it's not working properly

Would like to know what Eugene thinks about those points.

  1. City/Town lookup is case sensitive - can we capitalize the word and do the lookup OR lowercase lookups being returned? I don't expect the user to capitalize it themselves.

  2. Date of birth field is automatically set to the current date. Can we set it to at least 18 years ago.

  3. Register button doesn't work. I see an ajax call to save_dojo_lead but the form doesn't go to the next page. Tried this in Chrome and Firefox. - Fixed

Rosa did get to look at it last week so her feedback includes the steps past Champion Registration. I'll provide more feedback when it is fixed.

Here's a list of feedback from Rosa:

  • DOB - should be able to be entered by text - not just flick through calendar - I have added date dropdown select menus instead of the calendar. I don't think it's a good idea to let the user type in a date as there needs to be a consistency with date format. Let me know what you think.
  • Phone Number - Should not autofill, don't know if this is just me or not but other peoples numbers are appearing below here :/ May just be random numbers stored on this comp somewhere :/ - Fixed
  • Get rid of team & venue question on the Reg form - Fixed
  • Add the 2 additional fields (from our salesforce form) beside tech mentors & venue checkboxes where people have text fields to explain where or a bit on their team. - Fixed
  • Gather Team and Find Venue are interchangable - you should be able to move from one to the other without completing the other - The wizard works by applying validation at each step when the user clicks submit. We have two required fields in the Gather Team step (Gather Team checkbox and Find Mentors checkbox), so allowing the user to continue without completing this step would mean making these fields optional. An alternative would be to merge the Gather Team and Find Venue into one step
  • Proof/sentence on how your team is background checked. - Fixed
  • Background checking is an optional field (unfortunately)
  • Dojo Content should be changed to Plan your Dojo with the following checkboxes;-Fixed
    Plan how frequently you will run*
    Social Media (optional)
    Website (optional)
    Set the date*
    first date of your Dojo is;
  • Plan the content you will use - Fixed
  • Confused about the Place field on Dojo listing - not necessary
  • Should we move status messages/ supporters image url into central field? People often miss this at the minute and ignore changing this from default.
  • Supporters image URL - could also include upload image.
  • Mailing list has no tick box :( -Fixed
@tangentfairy-zz
Copy link
Member

If you guys want I can put issues into separate smaller Github issues in the future - whatever works best for you.

@dberesford dberesford added this to the Phase 1 milestone May 6, 2015
@david-cahill
Copy link

Hi @tangentfairy, I've just added some of my comments in bold above, thanks!

@tangentfairy-zz
Copy link
Member

That's great thank you!

The day/month/year fields on the second step seem to be blank when I first get to the registration step. They show up on a page refresh.

@tangentfairy-zz
Copy link
Member

The Registration button is still not working for me. This is after a full page refresh.

@david-cahill
Copy link

@tangentfairy ok it could be a validation issue, are you filling in all of the required fields? I'll check it out anyway :)

@tangentfairy-zz
Copy link
Member

Yes I filled out all the fields and I don't see any validation errors. There is a POST to save_dojo_lead being executed. The response is a 502.

@david-cahill
Copy link

I'm wondering if it's an issue with the server, it seems to take some time to load the site. I'll have a look anyway :)

@david-cahill
Copy link

@tangentfairy I've deployed the latest changes to the server now, the champion registration should work :)

@tangentfairy-zz
Copy link
Member

Works now, thanks a million!

@dberesford
Copy link
Contributor Author

Assigning to @ckiss, can you please close this when you fix CoderDojo/cp-zen-platform#96

@ckiss
Copy link
Contributor

ckiss commented May 12, 2015

CoderDojo/cp-zen-platform#96 has been closed. I'll close this too.

@ckiss ckiss closed this as completed May 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants