Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently only works on python>=3.9 #4

Closed
CoderJoshDK opened this issue Aug 23, 2022 · 2 comments
Closed

Currently only works on python>=3.9 #4

CoderJoshDK opened this issue Aug 23, 2022 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@CoderJoshDK
Copy link
Owner

Currently, the API does not work for versions before python 3.9.

If you try to use an earlier version, you will get a TypeError: 'type' object is not subscriptable.

The issue comes from wiopy/arguments.py:

def get_items_ids(items: Union[str, list[str]]) -> list[str]:
    if not isinstance(items, str) and not isinstance(items, list):
        raise InvalidParameterException('Invalid items argument, it should be a string or List of strings')
    ...

list type casting only works for python>=3.9
To fix, import List


This issue will be fixed. I (the developer) am a little busy. But I will fix this issue and update pypi

@CoderJoshDK CoderJoshDK added bug Something isn't working good first issue Good for newcomers labels Aug 23, 2022
@CoderJoshDK CoderJoshDK self-assigned this Aug 23, 2022
@CoderJoshDK
Copy link
Owner Author

CoderJoshDK commented Aug 23, 2022

This commit fixes the issues. It will be a bit before PyPI is updated with a new version.
This issue was brought up by Issue #3

@CoderJoshDK
Copy link
Owner Author

Why has this not been done yet? It should be an easy fix, right?


Easy? Well, yes, but actually no.

tldr; I am busy and do still plan to update things

The issue is that my method of uploading to PyPI sucks. I hate it. And there are other little changes that I want to make to this package. This issue is minor and will be fixed in the next update. But it requires changes that I do not have experience in. Meaning it requires time. Time is something I am a little short on. This is a low priority. But once I have some time to experiment with the changes I want, I will do that and close this issue.

Thank you for your patience and understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant