feat: adding legacy grpc lib support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Farenheith
requested review from
danielgalleni,
DanielM08,
douglasdrdc,
fgabrielsilva,
icarolettieri,
jeeo and
pedrosodre
Farenheith
force-pushed
the
old-grpc-support
branch
3 times, most recently
from
d37ded3
to
4f62efc
Compare
gustavo-rodrigues-dev
previously approved these changes
Jan 7, 2023
BREAKING CHANGE: The library contract needed to be changed in order to keep functionalities compatible between both versions. Although the contract must be almost equal some things like error catching have behaved differently between them. Due to that, we chose an approach that works for both packages, but we need to break the contract.
Farenheith
force-pushed
the
old-grpc-support
branch
from
4f62efc
to
8344db8
Compare
gustavo-rodrigues-dev
approved these changes
Jan 7, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
codibrebot
pushed a commit
that referenced
this pull request
Jan 7, 2023
# [2.0.0](v1.4.0...v2.0.0) (2023-01-07) ### Features * adding legacy grpc lib support ([#9](#9)) ([45a7f3d](45a7f3d)) ### BREAKING CHANGES * The library contract needed to be changed in order to keep functionalities compatible between both versions. Although the contract must be almost equal some things like error catching have behaved differently between them. Due to that, we chose an approach that works for both packages, but we need to break the contract.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows you to use the legacy gRPC package if you need to.
Although the legacy package is deprecated, the new one presents a memory leak behavior that is yet to be solved. You can follow the issue here.
BREAKING CHANGE: The library contract needed to be changed in order to keep functionalities compatible between both versions. Although the contract must be almost equal some things like error catching have behaved differently between them. Due to that, we chose an approach that works for both packages, but we need to break the contract