Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the case that location of missing characters is not known. #1

Closed
Coding-Enthusiast opened this issue Jan 16, 2020 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@Coding-Enthusiast
Copy link
Owner

Base-58 service only supports the case when the user knows the location of missing characters.
A new option is needed for when that location is not known. But the option has to work with any number of missing characters without needing to hard-code each case individually.

@Coding-Enthusiast Coding-Enthusiast added the enhancement New feature or request label Jan 16, 2020
@Coding-Enthusiast
Copy link
Owner Author

73e8596 solves this for a special case (compressed key missing 3 chars).
We can add more code for a couple more small cases (3 missing is already 4 billion keys to check).

@Coding-Enthusiast
Copy link
Owner Author

305a535 solves this for special case (both compressed and uncompressed keys missing 1 char).

@Coding-Enthusiast
Copy link
Owner Author

8d13be8 solves this for special case (both compressed and uncompressed keys missing 2 chars) which closes this issue.

We can add the case for >= 4 chars missing but the number of keys to check grows fast and the colde also becomes very slow 2.9k -> 4.2 mil -> 4.0 bil -> 2.8 tril -> 1.5 quad.
I prefer postponing any additional work on this to after code including SHA got more optimized (eg. using SIMD) and GPU support is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant