Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistent_comment option for /describe #835

Closed
hnoson opened this issue Apr 2, 2024 · 6 comments
Closed

Add persistent_comment option for /describe #835

hnoson opened this issue Apr 2, 2024 · 6 comments

Comments

@hnoson
Copy link

hnoson commented Apr 2, 2024

The comment isn't replaced and there is no option to do it when publish_description_as_comment is enabled.

@mrT23
Copy link
Collaborator

mrT23 commented Apr 2, 2024

its possible

why do you want to use at all the mode of 'publish_description_as_comment' for describe ?

@hnoson
Copy link
Author

hnoson commented Apr 2, 2024

since we update the description manually and it's sometimes overwritten by the generated one

@mrT23
Copy link
Collaborator

mrT23 commented Apr 2, 2024

unclear

What's your use case for using publish_description_as_comment at all ? why not write directly to the PR header ?
It does not overwrite the original content, it adds to it:

https://pr-agent-docs.codium.ai/usage-guide/automations_and_usage/#github-app-automatic-tools-when-a-new-pr-is-opened

@hnoson
Copy link
Author

hnoson commented Apr 2, 2024

  1. Open a PR
  2. Start editing the description manually
  3. PR-Agent generates content based on the content before editing
  4. Finish editing manually
  5. The manual edit or PR-Agent overwrites content of the other

To avoid this issue, we enabled publish_description_as_comment

@mrT23
Copy link
Collaborator

mrT23 commented Apr 2, 2024

#837
done

image

@mrT23 mrT23 closed this as completed Apr 2, 2024
@hnoson
Copy link
Author

hnoson commented Apr 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants