You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The Rochester corrections of given by coffea.lookup_tools.rochester_lookup.rochester_lookup are not compatible with dask_awkward. In particular, trying to execute kSmearMC on dask_awkward arrays will give a NotImplementedError. The reason seems to be that it uses scipy.stats functionality (through doublecrystalball).
@ssrothman is working on a correctionlib version of the rochester corrections so maybe this ends up fixing the issue in general.
For the current version in coffea I intend to get it working with dask awkward. I can likely knock it out this month but there are other things that need attention first. I suspect that the fix is not that bad, probably just wrapping some stuff in map_partitions.
As a library developer it may be a useful exercise for you to implement that part ( and submit it as a PR to coffea ;-) ).
Describe the bug
The Rochester corrections of given by
coffea.lookup_tools.rochester_lookup.rochester_lookup
are not compatible with dask_awkward. In particular, trying to executekSmearMC
on dask_awkward arrays will give a NotImplementedError. The reason seems to be that it usesscipy.stats
functionality (throughdoublecrystalball
).To Reproduce
Where
tests/samples/RoccoR2018.txt.gz
can be found in the coffea repository.Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: