Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Committing offset before file commit leads to data loss #63

Open
vishal-bihani opened this issue Oct 14, 2022 · 0 comments
Open

Committing offset before file commit leads to data loss #63

vishal-bihani opened this issue Oct 14, 2022 · 0 comments
Assignees
@vishal-bihani

Comments

@vishal-bihani
Copy link
Contributor

Describe the bug
In TopicPartitionWriter the last successful offset is recorded just after the record is processed by the RecordWriter. If the data upload fails then it won't replay the lost messages.

Expected behavior
Offset commit should happen only after successful file commit & upload.
@vishal-bihani vishal-bihani self-assigned this Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishal-bihani vishal-bihani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vishal-bihani