Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mod] names output parses links/invites #2555

Open
MeatyChunks opened this issue Apr 5, 2019 · 3 comments
Open

[Mod] names output parses links/invites #2555

MeatyChunks opened this issue Apr 5, 2019 · 3 comments
Labels
Category: Cogs - Mod This is related to the Mod cog. Status: Needs Discussion Needs more discussion. Type: Enhancement Something meant to enhance existing Red features.

Comments

@MeatyChunks
Copy link
Contributor

Command bugs

Command name

names

What cog is this command from?

Mod

What were you expecting to happen?

As a precaution Discord invites/URLs should be cleaned on the command's output.

What actually happened?

If a user sets their name to a discord invite or other URL it's parsed on the list of past nicknames.

How can we reproduce this issue?

Set a user's nickname to a url/invite, then use the names command on them.
@mikeshardmind
Copy link
Contributor

[p]userinfo Has prior nickname builtin with invites filtered. I think having access to the unfiltered names for mod use in [p]names is still useful. I suggest locking the command to your mod/admin role using permissions.

@Twentysix26 Twentysix26 added Status: Needs Discussion Needs more discussion. Type: Enhancement Something meant to enhance existing Red features. labels Apr 16, 2019
@Jackenmen Jackenmen added the Category: Cogs - Mod This is related to the Mod cog. label Jan 16, 2020
@Dav-Git
Copy link
Contributor

Dav-Git commented Jun 25, 2020

What are our thoughts on this? Personally agree with Sinbad here. Should this be closed or shall I make a PR?

@Jackenmen
Copy link
Member

I agree that having access to unfiltered names is indeed useful. We could, however, perhaps lock the command to the mod role by default. I'm not entirely sure it is a good idea and would appreciate more opinions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Cogs - Mod This is related to the Mod cog. Status: Needs Discussion Needs more discussion. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Jackenmen @MeatyChunks @Twentysix26 @mikeshardmind @Dav-Git