[Docs] Add awaits and missing imports in usage examples #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackenmen
changed the title
Jackenmen
changed the title
- Cogs should inherit from `commands.Cog` - `modlog.create_case()` should take the bot as its first argument, and doesn't require the `until` or `channel` arguments - It's better style, and more reliable, to use an asynchronous `initialize()`, method than it is to spawn a background task on load. - Casetypes should use actual UTF-8 characters where possible since `:emoji:` doesn't get rendered in embeds Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
mikeshardmind
added
the
Category: Docs - Other
Tobotimus
approved these changes
Jul 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
Well, the modlog examples had to be changed a lot, because
awaitobviously won't work in regular method. I used the same way as it's done in core code.