Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startrek Trivia list #2946

Merged
merged 10 commits into from Nov 6, 2023
Merged

Conversation

scarecr0w12
Copy link
Contributor

Star trek trivia list

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Star trek trivia list

Star trek list from old redbot formatted for current YAML
@Flame442 Flame442 added Category: Cogs - Trivia - Lists Changing or adding trivia lists. Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. Type: Enhancement Something meant to enhance existing Red features. labels Aug 22, 2019
@Flame442 Flame442 removed the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Aug 22, 2019
@Vexed01
Copy link
Contributor

Vexed01 commented Aug 23, 2019

Please note that the bot is case sensitive with answers. As an example in line 5 you put the single answer as pennsylvania. This means that the bot will mark Pennsylvania incorrect. That question would ideally look like this:

In What State Is Carbon Creek Located?:
- pennsylvania
- Pennsylvania

@scarecr0w12
Copy link
Contributor Author

Yeah i realized that after i got it set, im gonna go through the list again and add in alternative forms of the answers and capitalization. Wanted to get a first set up though.

@Jackenmen Jackenmen added this to the 3.4.4 milestone Nov 16, 2020
@Jackenmen Jackenmen modified the milestones: 3.4.4, 3.4.5 Dec 15, 2020
@Jackenmen Jackenmen modified the milestones: 3.4.6, 3.4.7 Jan 17, 2021
@Jackenmen Jackenmen modified the milestones: 3.4.13, 3.4.x Jun 25, 2021
@Flame442 Flame442 self-assigned this Aug 23, 2022
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're still interested in working on this (sorry for the 3 year wait), the questions should have normal English capitalization rules for a sentence (only capitalize the first letter and proper nouns) and a lot of these questions could use alternative answers, especially the dates and names, to accept a bit more variety in how a user could input the answer. Note that trivia is case insensitive for answers, so you do not need to add different casings, only different phrasings (august 19, 1921 could also be 8/19/1921 or 19/8/1921).

redbot/cogs/trivia/data/lists/startrek.yaml Outdated Show resolved Hide resolved
@Flame442 Flame442 added the QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. label Aug 23, 2022
Co-authored-by: Flame442 <34169552+Flame442@users.noreply.github.com>
@Kowlin Kowlin removed the QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. label Oct 19, 2022
@Kowlin Kowlin added the QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. label Oct 20, 2022
@aikaterna aikaterna self-assigned this Nov 1, 2022
Formatted the entire file properly, removed redundant or incomplete questions, clarified many questions and answers, added a couple questions.
@aikaterna aikaterna requested a review from Flame442 March 15, 2023 23:21
@aikaterna
Copy link
Member

This is ready for review, if there are any Star Trek nerds out there that would like to go over the changes to this file, besides my review request for Flame.

As a comment on this file for the future, the majority of the trivia questions are from Star Trek: The Original Series with a handful from The Next Generation, Voyager, Deep Space 9, and some of the older movies. If someone wanted to expand this list or add to it, I would suggest more entries from other parts of the Star Trek universe or spinoffs instead of the Original Series.

@aikaterna aikaterna removed the QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. label Mar 15, 2023
redbot/cogs/trivia/data/lists/startrek.yaml Outdated Show resolved Hide resolved
redbot/cogs/trivia/data/lists/startrek.yaml Outdated Show resolved Hide resolved
redbot/cogs/trivia/data/lists/startrek.yaml Outdated Show resolved Hide resolved
redbot/cogs/trivia/data/lists/startrek.yaml Outdated Show resolved Hide resolved
redbot/cogs/trivia/data/lists/startrek.yaml Outdated Show resolved Hide resolved
@Flame442 Flame442 modified the milestones: 3.5.x, 3.5.6 Nov 6, 2023
@Flame442 Flame442 enabled auto-merge (squash) November 6, 2023 21:48
@Flame442 Flame442 merged commit eb3267e into Cog-Creators:V3/develop Nov 6, 2023
16 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Nov 6, 2023
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Trivia - Lists Changing or adding trivia lists. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants