Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move our error handling to the cog base #3599

Open
Jackenmen opened this issue Feb 21, 2020 · 0 comments
Open

Move our error handling to the cog base #3599

Jackenmen opened this issue Feb 21, 2020 · 0 comments
Labels
Category: Core - API - Commands Package This is related to the `redbot.core.commands` package or `redbot.core.checks` module. Category: Core - Other Internals This is related to core internals that don't have a dedicated label. Status: Accepted We want this Status: Frozen We might make plans for this later. Type: Enhancement Something meant to enhance existing Red features.

Comments

@Jackenmen
Copy link
Member

Currently we handle errors in on_command_error event listener, moving this to cog base (or more likely to CogCommandMixin as not all commands are necessarily attached to a cog) would make it easier to override the error handling safely while retaining the behavior for people not overriding it.

Original issue: #3133
@Jackenmen Jackenmen added Type: Enhancement Something meant to enhance existing Red features. Status: Needs Discussion Needs more discussion. Category: Core - API - Commands Package This is related to the `redbot.core.commands` package or `redbot.core.checks` module. Category: Bot Core labels Feb 21, 2020
@Jackenmen Jackenmen added Status: Frozen We might make plans for this later. and removed Status: Needs Discussion Needs more discussion. labels Jun 27, 2021
@Flame442 Flame442 added the Status: Accepted We want this label Sep 25, 2022
@Jackenmen Jackenmen added Category: Core - Other Internals This is related to core internals that don't have a dedicated label. and removed Category: Bot Core labels Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Core - API - Commands Package This is related to the `redbot.core.commands` package or `redbot.core.checks` module. Category: Core - Other Internals This is related to core internals that don't have a dedicated label. Status: Accepted We want this Status: Frozen We might make plans for this later. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jackenmen @Flame442