Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make command errors translatable #3665

Merged
merged 5 commits into from Mar 23, 2020
Merged

Make command errors translatable #3665

merged 5 commits into from Mar 23, 2020

Conversation

Jackenmen
Copy link
Member

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes #2988

@Jackenmen Jackenmen added Type: Enhancement Something meant to enhance existing Red features. Category: Core - i18n This is related to the i18n core API or locale files. Category: Bot Core labels Mar 17, 2020
@Jackenmen Jackenmen requested a review from tekulvw as a code owner March 17, 2020 15:57
@Jackenmen Jackenmen added this to the 3.3.3 milestone Mar 19, 2020
Flame442
Flame442 requested changes Mar 22, 2020
View reviewed changes
redbot/core/events.py Outdated Show resolved Hide resolved
@Flame442 Flame442 self-assigned this Mar 22, 2020
@Jackenmen Jackenmen requested a review from Flame442 March 22, 2020 23:34
@Jackenmen Jackenmen added Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Mar 23, 2020
@Jackenmen Jackenmen merged commit 2cdf3c1 into Cog-Creators:V3/develop Mar 23, 2020
@Jackenmen Jackenmen deleted the jack1142-patch-4 branch March 23, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flame442 Flame442 Flame442 approved these changes

@tekulvw tekulvw Awaiting requested review from tekulvw

Assignees

@Flame442 Flame442

Labels
Category: Core - i18n This is related to the i18n core API or locale files. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
3.3.3
Development

Successfully merging this pull request may close these issues.

[i18n] Command errors (on_command_error event) aren't translated
2 participants
@Jackenmen @Flame442