New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing class docstrings in Downloader, Reports and Streams #3892
Merged
Jackenmen
merged 10 commits into
Cog-Creators:V3/develop
from
Vexed01:missing-docstrings
Jun 11, 2020
Merged
Add missing class docstrings in Downloader, Reports and Streams #3892
Jackenmen
merged 10 commits into
Cog-Creators:V3/develop
from
Vexed01:missing-docstrings
Jun 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idk what to say rly um hi all nice to be back after about 6 months pls no hate my PRs apoligies if i get in the way if you read this far then you deserve an achievement um i dunno what err how about the achievement of unboredness
oops lets not forget what tox checks for
Vexed01
requested review from
Jackenmen,
palmtree5,
tekulvw and
Twentysix26
as code owners
May 31, 2020 09:28
Jackenmen
reviewed
May 31, 2020
Flame442
added
the
Type: Enhancement
Something meant to enhance existing Red features.
label
Jun 5, 2020
Flame442
requested changes
Jun 5, 2020
Jackenmen
added
Category: Cogs - Downloader
This is related to the Downloader cog.
Category: Cogs - Streams
This is related to the Streams cog.
labels
Jun 5, 2020
Flame442
approved these changes
Jun 5, 2020
Flame442
added
the
QA: Passed
Used by few QA members. Has been approved by the assigned QA member(s).
label
Jun 5, 2020
Cog-CreatorsBot
added
the
Changelog Entry: Pending
Changelog entry for this PR hasn't been added by repo maintainers yet.
label
Jun 11, 2020
Jackenmen
added
Changelog Entry: Added
Changelog entry for this PR has already been added to changelog PR.
and removed
Changelog Entry: Pending
Changelog entry for this PR hasn't been added by repo maintainers yet.
labels
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: Cogs - Downloader
This is related to the Downloader cog.
Category: Cogs - Streams
This is related to the Streams cog.
Changelog Entry: Added
Changelog entry for this PR has already been added to changelog PR.
QA: Passed
Used by few QA members. Has been approved by the assigned QA member(s).
Type: Enhancement
Something meant to enhance existing Red features.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
Add the missing class docstrings in Downloader, Reports and Streams. Fixes #3232
Not tested (Windows 馃檮), though only docstrings so nothing should break. I hope.Edit: Got Windows to work and this doesn't break anything (no surprises there then, phew).