Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localwhitelist and localblacklist can both be non-empty at the same time #4001

Open
Jackenmen opened this issue Jun 21, 2020 · 0 comments · May be fixed by #4002
Open

localwhitelist and localblacklist can both be non-empty at the same time #4001

Jackenmen opened this issue Jun 21, 2020 · 0 comments · May be fixed by #4002
Labels
Category: Core - Bot Class This is related to the `redbot.core.bot.Red` class. Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.

Comments

@Jackenmen
Copy link
Member

Jackenmen commented Jun 21, 2020

Other bugs

Something I noticed when testing #3903 (but out of scope for it), removing last user from localwhitelist or clearing it makes the bot use the previously configured localblacklist as adding people to localwhitelist does not automatically clear localblacklist.

IMO, adding people to one of these lists when other isn't empty should prompt the user to clear the other before allowing the user to add people.

Edit: I forgot to add reproduction steps, here they are (Replace You with your username):

Pre-requirements: You can't be bot or guild owner

  1. Run both [p]localblacklist clear and [p]localwhitelist clear if they're not already empty
  2. Run [p]localwhitelist add You
  3. Run [p]localblacklist add You
  4. Run [p]localwhitelist remove You or [p]localwhitelist clear
  5. You can't run commands anymore because there was a blacklist you didn't know about configured
@Jackenmen Jackenmen added Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Category: Bot Core labels Jun 21, 2020
@Jackenmen Jackenmen added this to the Backlog milestone Jun 21, 2020
@github-actions github-actions bot added the Status: Needs Triage This has not been labeled or discussed for handling yet. label Jun 21, 2020
@Jackenmen Jackenmen added Status: In Progress There's a PR open to deal with this, or an org member is working on this internally and removed Status: Needs Triage This has not been labeled or discussed for handling yet. labels Jun 21, 2020
@Drapersniper Drapersniper modified the milestones: Backlog, 3.5.0 May 31, 2021
@Jackenmen Jackenmen removed this from the 3.5.0 milestone Jun 25, 2021
@Jackenmen Jackenmen added Category: Core - Bot Class This is related to the `redbot.core.bot.Red` class. Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). and removed Category: Bot Core labels Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core - Bot Class This is related to the `redbot.core.bot.Red` class. Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants