Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add nano package to Linux install guides #4870

Merged
merged 14 commits into from Mar 3, 2021

Conversation

OofChair
Copy link
Contributor

@OofChair OofChair commented Mar 3, 2021

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

As some servers don't have nano preinstalled, I added the installation instructions here.

As some servers don't have nano preinstalled, I added the installation instructions here.
@github-actions github-actions bot added the Category: Docs - Other This is related to documentation that doesn't have its dedicated label. label Mar 3, 2021
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest updating the sentence from L25-26 to say something like (you might want to phrase it differently though):

We recommend installing a nano text editor as our guides may instruct you to create or edit some files. We also recommend installing some basic compiler tools in case our dependencies don't provide pre-built "wheels" for your architecture.

docs/install_linux_mac.rst Outdated Show resolved Hide resolved
docs/install_linux_mac.rst Outdated Show resolved Hide resolved
docs/install_linux_mac.rst Outdated Show resolved Hide resolved
docs/install_linux_mac.rst Outdated Show resolved Hide resolved
docs/install_linux_mac.rst Outdated Show resolved Hide resolved
docs/install_linux_mac.rst Outdated Show resolved Hide resolved
@Jackenmen Jackenmen self-assigned this Mar 3, 2021
@Jackenmen Jackenmen added the Type: Enhancement Something meant to enhance existing Red features. label Mar 3, 2021
OofChair and others added 2 commits March 3, 2021 10:06
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
@Jackenmen Jackenmen added this to the 3.4.8 milestone Mar 3, 2021
OofChair and others added 5 commits March 3, 2021 10:06
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
@OofChair
Copy link
Contributor Author

OofChair commented Mar 3, 2021

Should be good now

@OofChair OofChair requested a review from Jackenmen March 3, 2021 15:12
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the follow-up!

@Jackenmen Jackenmen changed the title [Docs] Add installation instructions for nano [Docs] Add nano package to Linux install guides Mar 3, 2021
@Jackenmen Jackenmen merged commit 7789649 into Cog-Creators:V3/develop Mar 3, 2021
@Cog-CreatorsBot Cog-CreatorsBot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Mar 3, 2021
@OofChair OofChair deleted the patch-3 branch March 3, 2021 16:14
@Jackenmen Jackenmen modified the milestones: 3.4.9, 3.4.8 Apr 1, 2021
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants