Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use 0 point warnings again #5177

Closed
Jackenmen opened this issue Jul 3, 2021 · 2 comments · Fixed by #5178
Closed

Allow to use 0 point warnings again #5177

Jackenmen opened this issue Jul 3, 2021 · 2 comments · Fixed by #5178
Labels
Category: Cogs - Warnings This is related to the Warnings cog. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.

Comments

@Jackenmen
Copy link
Member

Paaain. We actively used 0 point warnings. This also was not in the CL

Originally posted by @Crossedfall in #5120 (comment)
@Jackenmen Jackenmen added this to the 3.4.13 milestone Jul 3, 2021
@Jackenmen Jackenmen added the Release Blocker This needs handling prior to the next non-hotfix release. label Jul 3, 2021
@github-actions github-actions bot added the Status: Needs Triage This has not been labeled or discussed for handling yet. label Jul 3, 2021
@Jackenmen Jackenmen added Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Status: Accepted We want this Category: Cogs - Warnings This is related to the Warnings cog. Status: PRs Welcome No one is currently assigned to this issue, but we'd be grateful if anyone made a PR. Good First Issue Good for beginners to the project. and removed Status: Needs Triage This has not been labeled or discussed for handling yet. labels Jul 3, 2021
@Jackenmen
Copy link
Member Author

Should be easy to fix, PRs welcome.

@Just-Jojo Just-Jojo mentioned this issue Jul 3, 2021
Merged
@Jackenmen Jackenmen added Status: In Progress There's a PR open to deal with this, or an org member is working on this internally and removed Status: Accepted We want this Status: PRs Welcome No one is currently assigned to this issue, but we'd be grateful if anyone made a PR. Good First Issue Good for beginners to the project. labels Jul 3, 2021
@Jackenmen Jackenmen removed this from the 3.4.13 milestone Jul 3, 2021
@Jackenmen Jackenmen removed the Release Blocker This needs handling prior to the next non-hotfix release. label Jul 3, 2021
@Jackenmen
Copy link
Member Author

@Crossedfall Just to let you know what has happened here - we've accidentally released a few commits we didn't originally intend to which is why the changelog you see in the stable docs is not fully accurate (it will be once the next release is made). The change would have been released eventually either way (and fixed in next after your report :)) but it would be listed in the changelog which hasn't happened here so sorry about that. We've made some adjustments to the release process to hopefully avoid this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Cogs - Warnings This is related to the Warnings cog. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Warnings] Allow for 0 point warnings Just-Jojo/Red-DiscordBot
1 participant
@Jackenmen