[Mod] Account for roles in mention spam #5388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Category: Cogs - Mod
Kowlin
added
the
Type: Enhancement
Kowlin
approved these changes
Oct 20, 2022
red-githubbot
bot
added
the
Changelog Entry: Pending
Jackenmen
pushed a commit
to Jackenmen/Red-DiscordBot
that referenced
this pull request
Nov 1, 2022
Co-authored-by: Kowlin <10947836+Kowlin@users.noreply.github.com>
Drapersniper
pushed a commit
to Drapersniper/Red-DiscordBot
that referenced
this pull request
Nov 27, 2022
Co-authored-by: Kowlin <10947836+Kowlin@users.noreply.github.com>
Drapersniper
pushed a commit
to Drapersniper/Red-DiscordBot
that referenced
this pull request
Dec 2, 2022
Co-authored-by: Kowlin <10947836+Kowlin@users.noreply.github.com>
Red-GitHubBot
pushed a commit
to Red-GitHubBot/Red-DiscordBot
that referenced
this pull request
Apr 19, 2023
(cherry picked from commit 3be22b6) Co-authored-by: Vexed <vex@vexcodes.com> Co-authored-by: Kowlin <10947836+Kowlin@users.noreply.github.com>
Jackenmen
pushed a commit
that referenced
this pull request
Apr 19, 2023
Jackenmen
added
Changelog Entry: Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add up both user and role mentions when checking for mention spam, fixes #4471
The discussion on the original issue did not come to a conclusion on which way to implement this. For both end-user and code simplicity (and my personal preference), I have chosen to not add separate trigger values to config and their associated new commands, instead just totalling up role + user mentions. I would be happy to expand on this and implement one of the variations in the original issue if this is what is preferred, such as separate customisation for user mentions/role mentions.