[modlog] Use new audit log event #5970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Category: Core - Modlog
palmtree5
added
Blocked By: Dependency
Kowlin
removed
the
Blocked By: Dependency
Flame442
approved these changes
Dec 26, 2023
There was a problem hiding this comment.
This works fine, and greatly simplifies the code. However, this will cause a potential ""breaking"" change, in the sense that the bot requires the It already needed it to read from the audit log after the event was triggered :Pview_audit_log permission bit in order to get this event for a server. We should probably note this in the changelogs as a minor thing to be aware of if we are going to go forward with this change.
|
Hhhmmmmmm. While I'm a bit wary about losing the on ban stuff, I think overall this is a very welcome change and I'm fine with merging it like this. |
red-githubbot
bot
added
the
Changelog Entry: Pending
Jackenmen
added
Changelog Entry: Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Uses the new audit log event instead of polling the audit logs on member ban / unban. Depends on an update to discord.py.
Have the changes in this PR been tested?