Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The fuzzy search for local search doesn't seem to be matching fully #6129

Closed
Sohl42 opened this issue May 5, 2023 · 1 comment · Fixed by #6224
Closed

The fuzzy search for local search doesn't seem to be matching fully #6129

Sohl42 opened this issue May 5, 2023 · 1 comment · Fixed by #6224
Assignees
Labels
Category: Cogs - Audio This is related to the Audio cog. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.

Comments

@Sohl42
Copy link

Sohl42 commented May 5, 2023

What Red version are you using?

3.5.1

Cog name

Audio

Command name

local search

What did you expect to happen?

Having a file structure as follows: "localtracks/numbered folder/artist - album.m4a"
I expected the command to return file results when searching a term like the artist or album name.
For example searching "tool" would return "295/Tool - Lateralus.m4a" etc.

What actually happened?

Searching album or artist names like "tool" and "lateralus" brings back "No matches.".
It does not matter what artist or album names I search it always says no matches.

How can we reproduce this error?

  1. Copy/create tracks in "localtracks" folder in the audio cog directory
  2. Boot redbot/load audio cog
  3. Use command [prefix]local search [term]

Anything else?

All of my files are named "Artist - Album.m4a" (I'm not doubling the file extension) inside numbered folders. i.e. 001, 002, etc.
Using the "local folder" command does work. ie. Typing "local folder 295" returns and plays the 295th folder as expected.

Debug Info for Red:

System Metadata:

CPU Cores: 12 (AMD64)
RAM: 13.7GB/31.9GB (42.8%)

OS variables:

OS version: Windows 10 (version 10.0.19045)
User: Name
Python executable: C:\Users\Name\Music\redenv\Scripts\python.exe
Python version: 3.11.3 (64bit)
Pip version: 23.1.2
Red version: 3.5.1
Discord.py version: 2.2.3

Red variables:

Instance name: Namebot
Owner(s): 137861053592764416 (Sohl#6054)
Disabled intents: None
Storage type: JSON
Data path: C:\Users\Name\Music\Namebot
Metadata file: C:\Users\Name\AppData\Local\Red-DiscordBot\Red-DiscordBot\config.json

@Sohl42 Sohl42 added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label May 5, 2023
@github-actions github-actions bot added the Status: Needs Triage This has not been labeled or discussed for handling yet. label May 5, 2023
@aikaterna aikaterna added the Category: Cogs - Audio This is related to the Audio cog. label May 5, 2023
@aikaterna aikaterna self-assigned this May 5, 2023
@Sohl42
Copy link
Author

Sohl42 commented Jun 13, 2023

Was randomly searching the Redbot discord to see if anyone else had this problem and saw that DarkSide1305 mentioned local search was only returning case sensitive results. I tested this out with using capitals in my search terms and it came back with correct results!
So it seems it's just case sensitivity that's the problem as far as I can tell.

@Jackenmen Jackenmen added Status: In Progress There's a PR open to deal with this, or an org member is working on this internally and removed Status: Needs Triage This has not been labeled or discussed for handling yet. labels Aug 10, 2023
@Jackenmen Jackenmen linked a pull request Aug 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Audio This is related to the Audio cog. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants