Include command-line arguments in debuginfo #6164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackenmen
added
the
Type: Enhancement
github-actions
bot
added
the
Category: Core - Command-line Interfaces
TrustyJAID
reviewed
Jun 21, 2023
Co-authored-by: TrustyJAID <TrustyJAID@gmail.com>
red-githubbot
bot
added
the
Changelog Entry: Pending
Jackenmen
added
Changelog Entry: Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
I thought it could be helpful in some cases, not sure how others feel about it. It is a bit better on Python 3.10 and higher as we can use
sys.orig_argvthere which is a more precise representation of arguments as received by the Python executable. Note that neithersys.argvnorsys.orig_argvis necessarily the same as what the user put in the command line, it's just thatsys.orig_argvallows you to get more information and allows you to differ between some cases that you otherwise couldn't.Have the changes in this PR been tested?
Yes