Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the view in [p]set api after timeout #6166

Merged
merged 2 commits into from Jun 20, 2023

Conversation

AAA3A-AAA3A
Copy link
Contributor

Description of the changes

Hello,

This PR disables the "Set API token" button of the redbot.core.utils.views.SetApiView view after the 180 seconds timeout. The logic is in the [p]set api command and not in the View itself, as Trusty would rather have.

Thanks in advance,
AAA3A

Have the changes in this PR been tested?

Yes

@github-actions github-actions bot added the Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). label May 18, 2023
@AAA3A-AAA3A
Copy link
Contributor Author

As Predä proposed, this PR now removes/clears the View from the message and edits the message ("This API keys setup message has expired.").

@AAA3A-AAA3A AAA3A-AAA3A changed the title [redbot.core.core_commands] Disable the SetApiView button after timeout. [Core Commands] Clear the SetApiView View and edit message after timeout. May 20, 2023
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Jackenmen Jackenmen added this to the 3.5.3 milestone Jun 20, 2023
@Jackenmen Jackenmen added the Type: Enhancement Something meant to enhance existing Red features. label Jun 20, 2023
@Jackenmen Jackenmen self-assigned this Jun 20, 2023
@Jackenmen Jackenmen changed the title [Core Commands] Clear the SetApiView View and edit message after timeout. Clear the view in [p]set api after timeout Jun 20, 2023
@Jackenmen Jackenmen merged commit b1c3b37 into Cog-Creators:V3/develop Jun 20, 2023
18 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Jun 20, 2023
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants