Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio NUMBER_EMOJIS tuple breakages from 3.5 #6169

Closed
Flame442 opened this issue May 19, 2023 · 0 comments · Fixed by #6170
Closed

Audio NUMBER_EMOJIS tuple breakages from 3.5 #6169

Flame442 opened this issue May 19, 2023 · 0 comments · Fixed by #6170
Assignees
@Kreusada
Labels
Category: Cogs - Audio This is related to the Audio cog. Good First Issue Good for beginners to the project. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.

Comments

@Flame442
Copy link
Member

This location in Audio currently attempts to mutate NUMBER_EMOJIS, which was mutable prior to 3.5, but is now immutable. It needs to be updated to properly account for this breaking change.

Red-DiscordBot/redbot/cogs/audio/core/utilities/playlists.py

Lines 265 to 266 in f47d1df

available_emojis = ReactionPredicate.NUMBER_EMOJIS[1:]
available_emojis.append("🔟")

@Flame442 Flame442 added Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Good First Issue Good for beginners to the project. Status: PRs Welcome No one is currently assigned to this issue, but we'd be grateful if anyone made a PR. Category: Cogs - Audio This is related to the Audio cog. labels May 19, 2023
@Flame442 Flame442 added this to the 3.5.3 milestone May 19, 2023
@Kreusada Kreusada self-assigned this May 19, 2023
@Kreusada Kreusada mentioned this issue May 19, 2023
Merged
@Kreusada Kreusada added Status: In Progress There's a PR open to deal with this, or an org member is working on this internally and removed Status: PRs Welcome No one is currently assigned to this issue, but we'd be grateful if anyone made a PR. labels May 19, 2023
@Jackenmen Jackenmen removed this from the 3.5.3 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kreusada Kreusada

Labels
Category: Cogs - Audio This is related to the Audio cog. Good First Issue Good for beginners to the project. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix NUMBER_EMOJIS breakages inside Audio Kreusada/Red-DiscordBot
3 participants
@Jackenmen @Flame442 @Kreusada