Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass timeout to SimpleMenu #6173

Merged
merged 4 commits into from Jun 20, 2023
Merged

Pass timeout to SimpleMenu #6173

merged 4 commits into from Jun 20, 2023

Conversation

OmLanke
Copy link
Contributor

@OmLanke OmLanke commented May 23, 2023

Description of the changes

Pass the timeout parameter to SimpleMenu.

The timeout parameter is currently used by the reactions based menu.
Since it wasn't passed to SimpleMenu, buttons based menu used the default timeout of 180 seconds.

Have the changes in this PR been tested?

No

@github-actions github-actions bot added the Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` label May 23, 2023
@Flame442 Flame442 added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label May 23, 2023
Jackenmen
Jackenmen requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should update the view.timeout with the value of the timeout argument after line 108 inside the if to allow changes to the timeout after the view was created.

@Jackenmen Jackenmen added this to the 3.5.4 milestone Jun 20, 2023
@Jackenmen Jackenmen self-assigned this Jun 20, 2023
@OmLanke OmLanke requested a review from Jackenmen June 20, 2023 14:00
@Jackenmen Jackenmen modified the milestones: 3.5.4, 3.5.3 Jun 20, 2023
Jackenmen
Jackenmen approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a contribution to our project!

@Jackenmen Jackenmen merged commit 41204cc into Cog-Creators:V3/develop Jun 20, 2023
17 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Jun 20, 2023
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackenmen Jackenmen Jackenmen approved these changes

Assignees

@Jackenmen Jackenmen

Labels
Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.5.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OmLanke @Jackenmen @Flame442