Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort cogs alphabetically inside [p]cog list #6215

Merged
merged 3 commits into from Sep 13, 2023
Merged

Sort cogs alphabetically inside [p]cog list #6215

merged 3 commits into from Sep 13, 2023

Conversation

Kreusada
Copy link
Member

Description of the changes

Sorts the cogs displayed inside [p]cog list alphabetically which improves UX. Closes #6214.

Have the changes in this PR been tested?

Yes

@Kreusada Kreusada added this to the 3.5.4 milestone Jul 25, 2023
@Kreusada Kreusada requested a review from Jackenmen as a code owner July 25, 2023 10:33
@github-actions github-actions bot added the Category: Cogs - Downloader This is related to the Downloader cog. label Jul 25, 2023
@Kreusada Kreusada added the Type: Enhancement Something meant to enhance existing Red features. label Jul 25, 2023
Jackenmen
Jackenmen requested changes Aug 12, 2023
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting should be case-insensitive, please apply .lower() to the names when using them as sort key.

@Jackenmen Jackenmen self-assigned this Aug 12, 2023
Jackenmen
Jackenmen approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Jackenmen Jackenmen merged commit 5069f46 into Cog-Creators:V3/develop Sep 13, 2023
17 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Sep 13, 2023
@Jackenmen Jackenmen modified the milestones: 3.5.6, 3.5.5 Sep 14, 2023
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackenmen Jackenmen Jackenmen approved these changes

Assignees

@Jackenmen Jackenmen

Labels
Category: Cogs - Downloader This is related to the Downloader cog. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
3.5.5
Development

Successfully merging this pull request may close these issues.

Alphabetically sort installed cogs in [p]cog list
2 participants
@Kreusada @Jackenmen