Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom status support #6226

Merged
merged 6 commits into from Aug 10, 2023
Merged

Add custom status support #6226

merged 6 commits into from Aug 10, 2023

Conversation

PredaaA
Copy link
Member

@PredaaA PredaaA commented Aug 9, 2023

Description of the changes

This PR adds support for custom status in [p]set status command group.
Custom status for bots are now supported since August 8th 2023 discord/discord-api-docs#6345.

Have the changes in this PR been tested?

Yes.

@github-actions github-actions bot added the Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). label Aug 9, 2023
Jackenmen
Jackenmen requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the argument name something like text instead of name? Also, the argument name in the Arguments section of the docstring is wrong.

redbot/core/core_commands.py Outdated Show resolved Hide resolved
@Jackenmen Jackenmen added the Type: Feature New feature or request. label Aug 10, 2023
@Jackenmen Jackenmen added this to the 3.5.4 milestone Aug 10, 2023
@Jackenmen Jackenmen self-assigned this Aug 10, 2023
Jackenmen
Jackenmen requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update docs/cog_guides/core.rst.

@PredaaA
Copy link
Member Author

PredaaA commented Aug 10, 2023

You also need to update docs/cog_guides/core.rst.

Done

Jackenmen
Jackenmen reviewed Aug 10, 2023
View reviewed changes
docs/cog_guides/core.rst Outdated Show resolved Hide resolved
@PredaaA @Jackenmen
Update docs/cog_guides/core.rst
050948d 
Co-authored-by: Jakub Kuczys <me@jacken.men>
Jackenmen
Jackenmen approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Jackenmen Jackenmen merged commit 9e23c3a into Cog-Creators:V3/develop Aug 10, 2023
17 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Aug 10, 2023
@PredaaA PredaaA deleted the feat/custom-status branch August 10, 2023 00:56
Jackenmen added a commit to Jackenmen/Red-DiscordBot that referenced this pull request Aug 10, 2023
@PredaaA @Jackenmen
Add custom status support (Cog-Creators#6226)
8063255 
Co-authored-by: Jakub Kuczys <me@jacken.men>
@Rapptz
Copy link
Contributor

Rapptz commented Aug 10, 2023

I think this got merged too quick cause the API is still subject to change due to the awkwardness of it.

@Jackenmen
Copy link
Member

I saw approval on the dapi docs PR so I assumed it's good to go 😬

@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackenmen Jackenmen Jackenmen approved these changes

Assignees

@Jackenmen Jackenmen

Labels
Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Feature New feature or request.
Projects
None yet
Milestone
3.5.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PredaaA @Rapptz @Jackenmen