Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Picarto channel avatar in Streams cog #6230

Merged
merged 1 commit into from Aug 12, 2023
Merged

Fix Picarto channel avatar in Streams cog #6230

merged 1 commit into from Aug 12, 2023

Conversation

Leo40Git
Copy link
Contributor

Description of the changes

Fixes the thumbnail in embeds for Picarto channels starting a stream.
This PR gets the avatar URL from the avatar field in the returned data, instead of trying to make our own URL.

Have the changes in this PR been tested?

No

@github-actions github-actions bot added the Category: Cogs - Streams This is related to the Streams cog. label Aug 10, 2023
@Jackenmen Jackenmen self-assigned this Aug 12, 2023
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Aug 12, 2023
@Jackenmen Jackenmen added this to the 3.5.4 milestone Aug 12, 2023
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@Jackenmen Jackenmen changed the title streams: fix Picarto channel avatar in embed Fix Picarto channel avatar in Streams cog Aug 12, 2023
@Jackenmen Jackenmen merged commit 483682d into Cog-Creators:V3/develop Aug 12, 2023
18 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Aug 12, 2023
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Streams This is related to the Streams cog. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants