Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streams] Switch to Twitch's newer follower endpoint #6247

Merged

Conversation

karlsbjorn
Copy link
Contributor

Description of the changes

Switches to the newer non-deprecated follower endpoint for Twitch since the one we're using now is being decommissioned.
Closes #6246

Have the changes in this PR been tested?

Yes, with [p]twitchstream

@github-actions github-actions bot added the Category: Cogs - Streams This is related to the Streams cog. label Sep 6, 2023
Copy link
Member

@palmtree5 palmtree5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is actually not enough as the way we authenticate with Twitch's API at the moment results in an app access token, which is not enough to use /helix/channels/followers as that endpoint requires a user access token that has the moderator:read:followers scope and given we only use this information to get a follower count, it might be better to just remove it for the moment, or replace it with some other useful piece of information

@karlsbjorn
Copy link
Contributor Author

Not having the scope should be fine for our use case here, no? This is from the Twitch docs here: https://dev.twitch.tv/docs/api/reference/#get-channel-followers

image

Works fine in my testing. I definitely don't have that scope:

DiscordCanary_hXi4wv5GT2

@palmtree5
Copy link
Member

ya know, I think I read that line once, months ago when the change was first announced, but then when I read it when writing that review I missed that line lmao. Yeah, this should be perfect then

@palmtree5 palmtree5 dismissed their stale review September 6, 2023 18:38

hurr durr why don't I actually read every word of the API documentation lmao 🤪

@palmtree5 palmtree5 merged commit 64deccf into Cog-Creators:V3/develop Sep 6, 2023
17 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Sep 6, 2023
@karlsbjorn karlsbjorn deleted the streams-follows-shutdown branch September 6, 2023 18:43
@Jackenmen Jackenmen added this to the 3.5.5 milestone Sep 14, 2023
@Jackenmen Jackenmen added Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Streams This is related to the Streams cog. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[streams] Use of deprecated helix/users/follows endpoint
3 participants