Ask for confirmation when path passed to addpath seems incorrect #6330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackenmen
added
the
Type: Enhancement
github-actions
bot
added
Category: Docs - For Developers
|
What about adding on to this to make sure the path isn't within the Data or Install paths? |
Good idea, I disallowed anything under data and core paths completely (the install path is part of the data path). |
Flame442
approved these changes
Mar 27, 2024
red-githubbot
bot
added
the
Changelog Entry: Pending
Jackenmen
deleted the
ask_for_confirmation_on_potentially_incorrect_addpath
branch
Jackenmen
added
Changelog Entry: Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This is one of the most common issues encountered by beginner cog creators trying to use
[p]addpath, let's try to nudge them in the right direction!Suggestions on the message's content welcome, the distance between the question and the buttons doesn't sit right with me but I wasn't sure how to address this. Would it make sense to repeat the question?
Have the changes in this PR been tested?
Yes