Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'makensis.exe' is not recognized, building on Windows #33

Closed
justingeeslin opened this issue Jul 1, 2020 · 3 comments
Closed

'makensis.exe' is not recognized, building on Windows #33

justingeeslin opened this issue Jul 1, 2020 · 3 comments
Assignees
Labels
bug Something isn't working windows

Comments

@justingeeslin
Copy link
Member

Building on Windows returns the following message. What is NSIS? Why is it needed to build for Windows and not for Mac?

package-windows:
 [launch4j] Compiling resources
 [launch4j] Linking
 [launch4j] Wrapping
 [launch4j] Successfully created Y:\CogTool-Modern\res\..\dist\CogTool.exe
     [exec] 'makensis.exe' is not recognized as an internal or external command,
     [exec] operable program or batch file.
     [exec] Result: 1
@justingeeslin justingeeslin added bug Something isn't working windows labels Jul 1, 2020
@justingeeslin
Copy link
Member Author

Update: NSIS is the nullsoft Scriptable Install System, and this exe runs on windows and builds windows installers. The build.xml in its current form seems to expect the makensis.exe to be in the project directory, but it not a part of this repo.

@justingeeslin justingeeslin added the help wanted Extra attention is needed label Jul 9, 2020
@justingeeslin justingeeslin pinned this issue Jul 9, 2020
@justingeeslin justingeeslin removed the help wanted Extra attention is needed label Jul 30, 2020
@justingeeslin justingeeslin self-assigned this Jul 30, 2020
@justingeeslin
Copy link
Member Author

Made some progress on this. Will updated Build.xml to point to the NSIS.exe in the Program Files directory. Coming soon to develop.

@justingeeslin justingeeslin unpinned this issue Jul 30, 2020
@justingeeslin
Copy link
Member Author

This is now fixed.

In order to build on Windows, you must have NSIS installed. We assume that the NSIS exe will be found in Program Files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows
Projects
None yet
Development

No branches or pull requests

1 participant