Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show critical errors via MessageBox, not just recaf-launcher.log #10

Open
Yoticc opened this issue Apr 14, 2024 · 4 comments
Open

Show critical errors via MessageBox, not just recaf-launcher.log #10

Yoticc opened this issue Apr 14, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Yoticc
Copy link

Yoticc commented Apr 14, 2024

For example, when I open the launcher.jar it doesn't open, I don't see MessageBox with error, to understand what happened, I have to open recaf-launcher.log to find the line with an error.
In that case log is:

Attempting to resolve installed Recaf version...
Recaf jar file not found: 'C:\Users\u\AppData\Roaming\Recaf\recaf.jar'

It would be nice to see a MessageBox with error:

Recaf jar file not found:
``C:\Users\u\AppData\Roaming\Recaf\recaf.jar''.

I think it won't be a problem to make MessageBox display via jfx

@Col-E Col-E added enhancement New feature or request good first issue Good for newcomers labels Apr 15, 2024
@Col-E
Copy link
Owner

Col-E commented Apr 15, 2024

MessageBox display via jfx

The launcher has no dependency on JFX so it'd be in swing, but I agree this would be a nice to have feature for usability.

@Col-E
Copy link
Owner

Col-E commented Apr 27, 2024

Wait, are you saying when you open the launcher the GUI does not show up?

The way this works is that if you run it via java you get the CLI. But if you use javaw which is how most OS's pair .jar file associations you get the GUI. This is intentional, you don't wan the CLI to pop open dialog windows.

@Yoticc
Copy link
Author

Yoticc commented Apr 27, 2024

I think it's because I had jre8 and jre11 on my PC, but not jre17. This was fixed after installing jre17 when I tried to build the recaf-ui module. I used java -jar but at the same time tried java.exe and javaw.exe from jre8, as I remember

@zDEFz
Copy link

zDEFz commented May 17, 2024

pointing out the obvious, javaw is not existent on linux for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants