Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new effects #15

Open
ColOfAbRiX opened this issue Nov 23, 2020 · 0 comments
Open

Support for new effects #15

ColOfAbRiX opened this issue Nov 23, 2020 · 0 comments
Labels
feature New feature or request good first issue Good for newcomers

Comments

@ColOfAbRiX
Copy link
Owner

ColOfAbRiX commented Nov 23, 2020

Description

As a user of the figlet library I would like to use the Validated applicative to handle figlet errors or, at worse, add support for my own effect.
I would like figlet to have a package that wraps results in Validated and a package that directly exposes the generic effect F[_].

Implementation

Add two new packages in the figlet4s-effects project, one for Validated and one for generic and use the existing packages as starting point to implement this feature.

On a different thought this might require a rethink of the structure of the packages because, like it is now, when importing the effects library a whole lot of unwanted dependencies can be added. I.e. if I want to use support for Either I'm forced to depend on Cats. Do not proceed before taking a decision with this.

Notes

For small, self-contained library like figlet4s I believe in the "battery included" approach and easy integration. For this reason I don't want users to fiddle with conversions to and from effects that they are not currently using in their library and this is why I want to add support for the most common and reasonable effect in the Scala ecosystem.

@ColOfAbRiX ColOfAbRiX added feature New feature or request good first issue Good for newcomers labels Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant