Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all uses of assert with Exceptions #96

Open
Nava2 opened this issue Oct 12, 2016 · 0 comments
Open

Replace all uses of assert with Exceptions #96

Nava2 opened this issue Oct 12, 2016 · 0 comments

Comments

@Nava2
Copy link
Contributor

Nava2 commented Oct 12, 2016

assert is widely considered bad. It corrupts the stack and does not behave "appropriately."

All assert messages should be replaced with this or equivalent:

From:

assert module instanceof RegisterArray :
               "Passed non-RegisterArray to RegisterArray.copyDataTo()" ;

To:

checkArgument(module instanceof RegisterArray, "Passed non-RegisterArray to RegisterArray.copyDataTo()");
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant