Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement PlainDateTime family of classes #21

Open
5 tasks
willemneal opened this issue Mar 24, 2021 · 4 comments
Open
5 tasks

[Feature] Implement PlainDateTime family of classes #21

willemneal opened this issue Mar 24, 2021 · 4 comments

Comments

@willemneal
Copy link
Contributor

This is a tracking issue for implementing the following classes:

  • PlainDateTime
    • PlainDate
      • PlainMmothDay
      • PlainYearMonth
    • PlainTime
@ColinEberhardt
Copy link
Owner

I'd also suggest that both Instant and the complete Duration API are relatively easy starting points for a new contributor

@willemneal
Copy link
Contributor Author

@ashutoshvarma ^

@ashutoshvarma
Copy link
Contributor

Yeah, Duration and Instant seems relatively easy, do we need to support Instant.toZonedDateTime also?

Also, I have started on PlainTime and so far add and subtract are done.
@ColinEberhardt For tests, do we just port them from https://github.com/tc39/proposal-temporal/tree/main/polyfill/test/PlainTime?

@ColinEberhardt
Copy link
Owner

None of the ‘zoned’ types are implemented yet as they require the tricky logic which applies time zone specific offsets based on the IANA time zone database. I’m working on that at the moment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants