Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Chip for sub-category missing #91

Closed
rubenhorn opened this issue Dec 13, 2021 · 1 comment
Closed

[BUG]: Chip for sub-category missing #91

rubenhorn opened this issue Dec 13, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@rubenhorn
Copy link
Collaborator

Describe the bug
While the chip for the category (e.g. sustainability) is displayed, the chip for the sub-category (e.g. food) is missing from the crowdaction card/details page.

(Should they also be displayed on the list items?)

To Reproduce
Steps to reproduce the behavior:

  1. Open main screen/crowdaction details page

Screenshots
Screenshot_20211213-075058.png

Device information:

  • Device: moto g9 play
  • OS: Android 11
  • Version + build number: 1.0.0+264
@rubenhorn rubenhorn added the bug Something isn't working label Dec 13, 2021
@wizlif
Copy link
Collaborator

wizlif commented Dec 13, 2021

We are assuming that the subcategory will be null sometimes, so we do hide it if it is not provided in the data.

{
    "crowdactionID": "sustainability#food#veganMonth22-12",
    "title": "Vegan month 2022",
    "description": "Let's be vegan for a month",
    "category": "sustainability",
    "location": "NL#Amsterdam",
    "date_start": "2022-12-01",
    "date_end": "2022-12-31",
    "date_limit_join": "2022-12-20",
    "password_join": "myEvent-myCompany2022",
    "commitment_options": [
      {
        "id": "vegetarian",
        "label": "Becoming vegetarian",
        "description": "I will not eat any meat from any animal (including fish).",
        "requires": [
          {
            "id": "no-beef",
            "label": "Not eating beef",
            "description": "I will avoid eating beef (Goodbye stake)."
          }
        ]
      }
    ],
    "participant_count": 1,
    "top_participants": [
      {
        "name": "Peter Parker",
        "userID": "6620cf87-44ed-456e-9798-d5cbeb7fa10a"
      }
    ],
    "images": {
      "card": "https://images.unsplash.com/photo-1498837167922-ddd27525d352?ixlib=rb-1.2.1&ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&auto=format&fit=crop&w=640",
      "banner": "https://images.unsplash.com/photo-1498837167922-ddd27525d352?ixlib=rb-1.2.1&ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&auto=format&fit=crop&w=640"
    }
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants