Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Theme with light page color setting #6449

Open
Andreas-Kainz opened this issue May 26, 2023 · 6 comments
Open

Dark Theme with light page color setting #6449

Andreas-Kainz opened this issue May 26, 2023 · 6 comments
Labels
23.05 bug Something isn't working dark-mode

Comments

@Andreas-Kainz
Copy link
Contributor

as libreoffice has two settings for dark mode

  1. dark mode of the UI elemnts
  2. dark dokument page color

Can we have two UI elements one for dark mode (as it is now) which change 1. and 2. and a second UI element if the user want to switch 2. So by default dark mode mean 1. and 2. are dark but the user can overrule the dokument page color with light?

Office Dark Theme

image

Dark/Light document page color

image

I would prefer to have two buttons

  • one toggle for dark theme and
  • one toggle for dark background color
@Andreas-Kainz Andreas-Kainz added bug Something isn't working unconfirmed labels May 26, 2023
@Andreas-Kainz
Copy link
Contributor Author

OnlyOffice

image

@timur-g
Copy link
Contributor

timur-g commented May 30, 2023

If browser is set to dark (or OS set to Dark and browser inheriting), Online automatically sets dark document background.
That makes it a bug now, as most text is not readable if not Automatic.
I support having two buttons, one for Dark UI and another for Dark Tiles.
That should be #4742.

image

@Tex2002ans
Copy link
Contributor

Tex2002ans commented Jun 7, 2023

Can we have two UI elements one for dark mode [...]

Yes. Fully agree.

Separating out the:

  • UI + Page Color

for Dark Mode is key.

In LibreOffice's Bug #153334: "Support/default to a non-white page background in Dark Mode", I wrote:

Having an easy-to-access "page color" toggle would help, because all 4 options could be taken:

  • Light UI + White Page
  • Light UI + Dark Page
  • Dark UI + White Page
    • (This is what I prefer most of the time.)
  • Dark UI + Dark Page

This is especially helpful when dealing with colors + contrast issues.

Automatically turning on a DARK PAGE as well, is just asking for all sorts of color/contrast troubles too.

(Already see black-on-black text or very-dark-text-on-dark-background issues.)


Side Note: Over the years, I've written extensively about this "black-on-black text" problem in ebooks:

and, related:

where I described "Inverting Colors" properly or "Dark Moding" your PDFs. For example, see:

You can look to many of these other projects for:

  • inspiration
  • + warnings of what type of issues/complaints are coming down the pipeline when you flip background colors. :)

@derei
Copy link

derei commented Mar 24, 2024

I see the last discussion on this topic is from June 2023, and I wanted to ask if is it possible to have dark theme with white page, or not just yet?
As many others have suggested, white page is a necessity for any document processor. Usually people want to print on paper their documents, and working on a dark page, even if output is reversed, makes it extremely difficult to work with images, charts, colours in general, in an intuitive and predictable manner.

Perhaps from developer perspective this may not seem as an urgent matter, but from user perspective it can easily become a deal breaker, especially in professional environments.

@Ornanovitch
Copy link

I believe there is a recent PR that solve this: #8564

Would be nice to see this merged :)

@derei
Copy link

derei commented Mar 24, 2024

I believe there is a recent PR that solve this: #8564

Would be nice to see this merged :)

I hope it will. I'm not very familiar with the specifics of Collabora code, but judging by that snippet alone, I see no reason why it shouldn't be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
23.05 bug Something isn't working dark-mode
Projects
Status: No status
Development

No branches or pull requests

6 participants