Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdowns have wrong mark color in browsers #7451

Closed
timur-g opened this issue Oct 16, 2023 · 7 comments
Closed

Dropdowns have wrong mark color in browsers #7451

timur-g opened this issue Oct 16, 2023 · 7 comments
Labels
23.05 bug Something isn't working dark-mode

Comments

@timur-g
Copy link
Contributor

timur-g commented Oct 16, 2023

Calc Format cells has wrong mark color, also other dropdowns.

Firefox 118 - Light NOK
image

Firefox Dark OK
image

Chromium 118 - Light OK
image

Chromium Dark NOK
image

Seen with Online 23.05.5.1.
Please write both Online and browser version where tested. Not sure if Online or browser change.

@Ezinnem please test. @Darshan-upadhyay1110 please keep in mind.

@Darshan-upadhyay1110
Copy link
Contributor

@timur-g

Firefox 118- Dark OK
image

Firefox 118 - Light OK
image

Chrome 117 - Dark OK
image

Chrome 117 - Light NOK
image

@timur-g i have expirenced slightly diffrent then issue discription.

@timur-g
Copy link
Contributor Author

timur-g commented Oct 17, 2023

Note: gridlines in Firefox are their regression, reported.

@timur-g timur-g changed the title Format Cells has wrong mark color Dropdowns have wrong mark color in browsers Oct 18, 2023
@Ezinnem
Copy link
Member

Ezinnem commented Oct 18, 2023

I see this issue when using the Nextcloud.

In Chrome (Light Mode): Not OK

format-cell-using-Nextcloud-Light

In Chrome (Dark Mode) - OK
format-cell-using-Nextcloud-Dark

In Firefox (Light Mode): OK

Firefox-format-cells-Light

In Firefox (Dark Mode): OK

Firefox-Format-cells--darkmode

@pedropintosilva
Copy link
Contributor

pedropintosilva commented Oct 18, 2023

I have tested on light mode

I couldn't reproduce.

I had meeting with @Darshan-upadhyay1110
and it seems that the problem is not really with any of the Online bits instead it looks like sometimes a css variable is being sent with wrong value. Here is what I mean for the light mode, the following variable:

--nc-color-primary-element-light

sometimes has the correct "light" value #e5f0f5 and sometimes it comes with a "dark" color: #141f25

Maybe the problem is on Nextcloud side because I don't think it makes sense in any way to pass --nc-color-primary-element-light with a dark color

  • @Darshan-upadhyay1110 could you please file a richdocuments bug, ask where are the variables being set and ask if that wasn't a mistake. Don't forget to link this issue

@Darshan-upadhyay1110
Copy link
Contributor

Fix: nextcloud/richdocuments#3238

@Darshan-upadhyay1110
Copy link
Contributor

Backport PR to stable 27 :nextcloud/richdocuments#3242

@Darshan-upadhyay1110
Copy link
Contributor

Closing this issue as fix :nextcloud/richdocuments#3238 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
23.05 bug Something isn't working dark-mode
Projects
Archived in project
Development

No branches or pull requests

4 participants