Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: don't boost / pretty print JSON for colors ... #8327

Closed
mmeeks opened this issue Feb 20, 2024 · 1 comment
Closed

perf: don't boost / pretty print JSON for colors ... #8327

mmeeks opened this issue Feb 20, 2024 · 1 comment
Labels
23.05 24.04 bug Something isn't working performance Improving COOL performance

Comments

@mmeeks
Copy link
Contributor

mmeeks commented Feb 20, 2024

It seems that @quikee used the boost::json stuff in error when getting the theme color work done:

svx/source/theme/ThemeColorChangerCommon.cxx-        if (rDocumentColors.size())
svx/source/theme/ThemeColorChangerCommon.cxx-            PaletteManager::generateJSON(aTree, rDocumentColors);
svx/source/theme/ThemeColorChangerCommon.cxx-
svx/source/theme/ThemeColorChangerCommon.cxx-        boost::property_tree::write_json(aStream, aTree);
svx/source/theme/ThemeColorChangerCommon.cxx-
svx/source/theme/ThemeColorChangerCommon.cxx:        SfxLokHelper::notifyAllViews(LOK_CALLBACK_COLOR_PALETTES, OString(aStream.str()));

@grandinj I wonder if you can re-work that to not use that thing; I've seen this code on a profile from @caolanm and wondered why; but it also generates huge, pretty-printed JSON which also seems unfortunate - bandwidth is not free - and 40k of mostly space characters is really not ideal for a message sent on start ;-)

@grandinj any chance we can switch to your nice tools:: JSON writer and get that into 23.05 and 24.05 ? =)

Thanks!

@mmeeks mmeeks added bug Something isn't working 23.05 performance Improving COOL performance 24.04 labels Feb 20, 2024
@grandinj
Copy link

grandinj commented Mar 4, 2024

@grandinj grandinj closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
23.05 24.04 bug Something isn't working performance Improving COOL performance
Projects
Archived in project
Development

No branches or pull requests

2 participants