Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: don't fetch font details we don't use ... #9096

Open
mmeeks opened this issue May 17, 2024 · 0 comments
Open

perf: don't fetch font details we don't use ... #9096

mmeeks opened this issue May 17, 2024 · 0 comments
Assignees
Labels
24.04 enhancement New feature or request

Comments

@mmeeks
Copy link
Contributor

mmeeks commented May 17, 2024

With the Notebookbar - and perhaps wiht the new font drop-down it seems we don't really use the result of this (very large) JSON we fetch: at least if this code changes get in: https://gerrit.libreoffice.org/c/core/+/167799

Then with something like this:

--- a/kit/SetupKitEnvironment.hpp
+++ b/kit/SetupKitEnvironment.hpp
@@ -46,7 +46,7 @@ inline void setupKitEnvironment(const std::string& userInterface)
}

 // Set various options we need.
  • std::string options = "unipoll";
  • std::string options = "unipoll:compact_fonts";
    if (userInterface == "notebookbar")
    options += ":notebookbar";

We can enable a very much smaller message with all the font details in it - but even so, we shouldn't fetch that if we don't need it in the
Notebookbar case surely (?).

@eszkadev can you think a bit on this and work out how best to handle this to be more efficient ? I'd guess step 1 - enable and switch to the new format in the UI if that's do-able, and step 2 - turn it off except for old-style toolbar ? =)

Thanks!

@mmeeks mmeeks added enhancement New feature or request 24.04 labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.04 enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants