Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue With runHTS.py #3

Closed
adwarner opened this issue Jan 25, 2018 · 3 comments · Fixed by #7
Closed

Issue With runHTS.py #3

adwarner opened this issue Jan 25, 2018 · 3 comments · Fixed by #7

Comments

@adwarner
Copy link

Hi,

Seems to be a bug when running runHTS.py in python 3. There is an issue with holidays producing ValueError: holidays must be a DataFrame with 'ds' and 'holiday' columns, despite it being clearly defined.
@mesk421
Copy link

mesk421 commented May 14, 2018

Hi,

There are any news about the "holidays" bug?
Alternatively, can I avoid specifying the holidays DataFrame, since my timeseries have monthly frequency?

@jordy-van-appeven
Copy link

This issue can be solved by chaning all prophet(..) Positional arguments to keyword arguments as explained here https://stackoverflow.com/questions/48450418/hts-prophet-holidays-issue/51400527#51400527

@emorfam emorfam mentioned this issue May 17, 2019
Merged
@emorfam
Copy link

emorfam commented May 20, 2019

Open PR
#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call fbProphet objects with keyword arguments emorfam/htsprophet
4 participants
@mesk421 @emorfam @adwarner @jordy-van-appeven