Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport weight #18

Closed
4 tasks done
mosemister opened this issue Oct 10, 2023 · 3 comments · Fixed by #22
Closed
4 tasks done

Transport weight #18

mosemister opened this issue Oct 10, 2023 · 3 comments · Fixed by #22
Assignees
Labels
development/todo by devs for devs enhancement New feature or request
Milestone

Comments

@mosemister
Copy link
Collaborator

mosemister commented Oct 10, 2023

When transporting on a line a player must be holding a select amount of items or lower to transport. This weight value should have a global default specified in the config file but each line may overwrite this value.

If a line does not overwrite this value and the config value changes, then the weight value should change too

  • create a config value for weight enabled of a boolean (default true)
  • create a config value for weight of a integer (default value of 500)
  • create a nullable integer of weight in the Line (if null then read config value when getting the value)
  • weight is calculated based on all items in the players inventory plus the items stack size
  • write tests
@mosemister mosemister added the enhancement New feature or request label Oct 10, 2023
@mosemister mosemister self-assigned this Oct 10, 2023
@ColonelKai
Copy link
Owner

Either add an additional boolean config value to remove this system or make it so that negative values disable the system.

I want this to be a disable-able module.

@ColonelKai ColonelKai added this to the 1.0 Release milestone Oct 10, 2023
@mosemister
Copy link
Collaborator Author

Ah shoot yes forgot that requirement. I personally dont like magic values even in configs so ill go with a enabled boolean

@ColonelKai
Copy link
Owner

Alright, either works for me. I want maximum customisability for my plugins.

@ColonelKai ColonelKai added the development/todo by devs for devs label Oct 10, 2023
@ColonelKai ColonelKai mentioned this issue Oct 10, 2023
6 tasks
@mosemister mosemister linked a pull request Oct 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development/todo by devs for devs enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants