Add Windows Support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hacky PowerShell script implementation adds support for Windows Altough the formating of the script is ugly to say the least, do NOT CHANGE the formatting, otherwise the script will break! I tested this on my Windows 11 and Windows 10 machine, and it seems to work fine :)
|
Looks good to me - but I would add a comment warning that the script formatting is meaningful, because otherwise someone (i.e. probably me) is going to break it later :p |
done! :) |
…the formatting issue
|
Ah, just realized I made a small mistake in the commit message, The open issue is in the PowerShell repo, NOT in the vscode-powershell repo, it was just referenced there and I overlooked that, Whoops |
|
Awesome, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hacky PowerShell script implementation adds support for Windows.
Although the formatting of the script is ugly, please do NOT CHANGE the formatting of the script, otherwise the script will break!
(Also I just noticed that my code formatting rules might not adhere to the previous code formatting rules, I do apologize for that!)
I tested this on my Windows 11 and Windows 10 machine, and it seems to work fine :)