Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor only - Camera Settings / Debug only sticking with restart of Plugin #75

Closed
Ghawken opened this issue Mar 20, 2018 · 2 comments
Closed

Comments

@Ghawken
Copy link

Ghawken commented Mar 20, 2018

Thanks

@Ghawken Ghawken changed the title Camera Settings / Debug only sticking with restart of Plugin Minor only - Camera Settings / Debug only sticking with restart of Plugin Mar 20, 2018
@Colorado4Wheeler
Copy link
Collaborator

Yes I'm aware, that's why that's in the instructions that you need to restart your camera plugin devices if you change the settings 😉. It's either that or come up with a convoluted method of going through ever server impacted by the change and restart them, which only happens if I track the initial settings first, which means capturing it before the dialog is open and stashing it separately..... So, as you can see, I had zero desire to spend an hour coding for the sake of telling someone to just restart the device. You shouldn't have to restart the plugin, I didn't, only the devices with cameras.

@Colorado4Wheeler
Copy link
Collaborator

Added to the next release.

Colorado4Wheeler pushed a commit that referenced this issue Mar 20, 2018
* Added sanity checker to the configuration save functions to validate
the folder structure and files to auto remove and rebuild the config
folder if it detects something is wrong, this hopefully to finally
close out the ongoing new-user-startup-issue that seems to always be
resolve by rebuilding the config ([Issue
#12](#12))
* Added URL message when the server cannot be started that points the
user to the wiki page explaining how to rebuild the Homebridge folder
if they are unable to start their server repeatedly
* Added threaded startup for servers when the plugin is loaded to speed
up the load time on the Homebridge servers
* Added validation on plugin preference save that will not permit the
user to save plugin prefs if there are any servers in a 'Starting' state
* Added validation on plugin preferences where if a camera field is
changed it will restart any servers impacted by that change (don't
blame me, Indigo API limitations) ([Issue
#75](#75)
* Added new Advanced Plugin Action for devices to log the contents of
the Homebridge configuration, mostly for camera debugging since it's
the only thing that actively manipulates the configuration
* Removed "under development" warnings from Advanced Plugin Actions
* Fixed bug in plugin config's packet size validation where it would
allow **any** value between 188 and 1316 instead of only values in
increments of 188
* Fixed minor UI issue where the 'Model' field was not automatically
populating when creating a new server
* [Issue
#75](#75)
feature added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants